[WIP] Fix TRAVIS_BRANCH #239
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
bdunne
commented
Dec 20, 2021
bdunne
commented
- This appears to be blank on master
- This appears to be blank on master
bdunne
force-pushed
the
fix_container_tag
branch
from
76c13fd
to
1108af3
Compare
|
Checked commit bdunne@1108af3 with ruby 2.6.3, rubocop 1.13.0, haml-lint 0.35.0, and yamllint **
|
|
I think it should be ref_name... That's what I was checking in my pr |
Fryguy
reviewed
Dec 20, 2021
| @@ -32,5 +32,5 @@ jobs: | |||
| - name: Run container build script | |||
| run: bin/build_container_image | |||
| env: | |||
| TRAVIS_BRANCH: ${{ github.ref }} | |||
There was a problem hiding this comment.
ref won't work because ref == "refs/heads/master" on a regular branch.
Merged
|
I opened #240 with my branch (we were doing it at the same time) |
|
This pull request is not mergeable. Please rebase and repush. |
|
Closing in favor of #240 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.