Merge pull request #553 from agrare/subclass_cinder_manager_openstack

Subclass CinderManagers under Openstack

db/migrate/20210118185402_subclass_cinder_manager_openstack.rb

@@ -0,0 +1,12 @@
+class SubclassCinderManagerOpenstack < ActiveRecord::Migration[6.0]
+  class ExtManagementSystem < ActiveRecord::Base
+    self.inheritance_column = :_type_disabled
+  end
+
+  def up
+    say_with_time("Subclass CinderManager under Openstack") do
+      ExtManagementSystem.where(:type => "ManageIQ::Providers::StorageManager::CinderManager")
+                         .update_all(:type => "ManageIQ::Providers::Openstack::StorageManager::CinderManager")
+    end
+  end
+end

spec/migrations/20210118185402_subclass_cinder_manager_openstack_spec.rb

@@ -0,0 +1,23 @@
+require_migration
+
+RSpec.describe SubclassCinderManagerOpenstack do
+  let(:ems_stub) { migration_stub(:ExtManagementSystem) }
+
+  migration_context :up do
+    it "Updates the CinderManager :type" do
+      ems = ems_stub.create!(:type => "ManageIQ::Providers::StorageManager::CinderManager")
+
+      migrate
+
+      expect(ems.reload.type).to eq("ManageIQ::Providers::Openstack::StorageManager::CinderManager")
+    end
+
+    it "Doesn't update other managers' types" do
+      ems = ems_stub.create!(:type => "ManageIQ::Providers::Vmware::InfraManager")
+
+      migrate
+
+      expect(ems.reload.type).to eq("ManageIQ::Providers::Vmware::InfraManager")
+    end
+  end
+end