Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetching the released migrations pollutes the local repo #6

Closed
Fryguy opened this issue Jun 20, 2017 · 1 comment
Closed

Fetching the released migrations pollutes the local repo #6

Fryguy opened this issue Jun 20, 2017 · 1 comment
Labels

Comments

@Fryguy
Copy link
Member

Fryguy commented Jun 20, 2017

When the migrations lived in ManageIQ proper, fetching a different branch locally was ok, because it was the same repo. Now that the schema has been separated out, fetching the ManageIQ/manageiq code into the ManageIQ/manageiq-schema repo pollutes the repo with the remote branches and tags. Unfortunately those tags will collide, for example when we cut gaprindashvili-1 on both repos, then try to fetch, you will get duplicate tag names, and I have no idea what will happen. We need an alternative now.

cc @carbonin

@Fryguy Fryguy added the bug label Jun 20, 2017
@carbonin
Copy link
Member

We had a few different versions of this. We used to hit the github API to get the migrations for a particular branch. We could resurrect that, but I think we were afraid of hitting the API rate limiter. Maybe that won't matter now that these specs are not running with every PR to the core repo?

Fryguy added a commit to Fryguy/manageiq-schema that referenced this issue Jun 21, 2017
This reverts the released migrations to using the GitHub API as was done
in 9fba1a4.  The concern for the GitHub
rate limits in 9568c7a is no longer a
problem now that migrations are in their own repo which should have much
less churn, unlike the main manageiq repo where the migrations would run
on *every* PR.

Fixes ManageIQ#6
Fryguy added a commit to Fryguy/manageiq-schema that referenced this issue Jun 22, 2017
This reverts the released migrations to using the GitHub API as was done
in 9fba1a4.  The concern for the GitHub
rate limits in 9568c7a is no longer a
problem now that migrations are in their own repo which should have much
less churn, unlike the main manageiq repo where the migrations would run
on *every* PR.

Fixes ManageIQ#6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants