Fetch released migrations via the GitHub API #14
Conversation
|
Looks good except for what looks like a missing require. |
This reverts the released migrations to using the GitHub API as was done in 9fba1a4. The concern for the GitHub rate limits in 9568c7a is no longer a problem now that migrations are in their own repo which should have much less churn, unlike the main manageiq repo where the migrations would run on *every* PR. Fixes ManageIQ#6
Fryguy
force-pushed
the
fetch_released_migrations_via_github_api
branch
from
08c8d52
to
bd5ce03
Compare
|
Checked commit Fryguy@bd5ce03 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
@Fryguy Travis Failure for Ruby 2.4 |
|
I don't understand it...I run Ruby 2.4 locally and it works just fine. It can't be something GitHub related or both versions would fail. @carbonin Maybe the sporadic failures in the past weren't because of rate limiting? |
|
Could be ... I also tried locally with 2.4 and didn't have any problems. Do you think it would pass if we re-run it? (not that this would be a good thing necessarily). |
Just kicked it...let's see |
|
😟 |
|
aaaand it's green |
|
OK, let's merge and deal with consequences if it's truly sporadic. @chessbyte Please merge. What we have here is better than not doing it, as not doing it means we leave devs with "broken" repos. |
This reverts the released migrations to using the GitHub API as was done
in 9fba1a4. The concern for the GitHub
rate limits in 9568c7a is no longer a
problem now that migrations are in their own repo which should have much
less churn, unlike the main manageiq repo where the migrations would run
on every PR.
Fixes #6
@carbonin Please review.