[WIP] Add switches.host_id to fix modeling/deletions #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently there is no association between either an EMS or a Host to their switches that don't go through host_switches. This means that switch deletions are "interesting". This also means that the manager_ref is not consistent because for shared switches uid_ems is unique but for host local switches the host is needed.
2 tasks
|
ManageIQ/manageiq#17420 Has the core model changes |
|
Checked commit agrare@ffda016 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
agrare
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there is no association between either an EMS or a Host to
their switches that don't go through host_switches. This means that
switch deletions are "interesting". This also means that the
manager_ref is not consistent because for shared switches uid_ems is
unique but for host local switches the host is needed.
See ManageIQ/manageiq#17383 for the problem description and
EmsRefresh.save_switches_inventoryfor what the old save_switches_inventory code looked like (:scream:)TODO:
Data migration to set ems_id for shared switches.