Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Fix switch modeling and deletions #17420

Closed

Conversation

agrare
Copy link
Member

@agrare agrare commented May 14, 2018

Fix the modeling of distributed and host-local switches. Currently switches are only referenced through host_switches which means we cannot do association based deletions.

This changes distributed_virtual_switches to be owned by the EMS, and host_virtual_switches to be owned by their host. This also means that the uid_ems is correctly unique under its parent, and deletions can be handled by the association and by cascade deletes.

Fixes #17383

Depends on: ManageIQ/manageiq-schema#200

TODO

@agrare agrare added the wip label May 14, 2018
@agrare agrare changed the title Add switch_uuid as secondary_refs to swiches [WIP] Fix switch modeling and deletions May 14, 2018
@agrare agrare requested a review from Ladas May 14, 2018 17:21
@agrare agrare force-pushed the fix_host_switch_modeling_and_deletions branch from ca322fa to f45f1fd Compare May 15, 2018 12:04
@miq-bot
Copy link
Member

miq-bot commented May 15, 2018

Checked commits agrare/manageiq@f48157d~...f45f1fd with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
6 files checked, 3 offenses detected

app/models/ems_refresh/save_inventory_infra.rb

app/models/manageiq/providers/infra_manager/distributed_virtual_switch.rb

@miq-bot
Copy link
Member

miq-bot commented Jun 12, 2018

This pull request is not mergeable. Please rebase and repush.

@agrare agrare closed this Jun 13, 2018
@agrare agrare deleted the fix_host_switch_modeling_and_deletions branch June 13, 2018 17:56
@agrare agrare restored the fix_host_switch_modeling_and_deletions branch July 12, 2018 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants