Create Canister migration

[EsdrasVP]

This PR is able to:

• Create a canister migration
• Add its reference to hardwares table

A Canister is a controller inside the Physical Storage (which may have more than one Canister). It contains its own firmware, ports, network, power state, etc.

Depends on:

• ManageIQ/manageiq-schema#233 - Merged
• ManageIQ/manageiq-schema#269
• ManageIQ/manageiq#17700 - Merged

[EsdrasVP]

@miq-bot assign @agrare

[agrare]

@EsdrasVP can you add to the PR description what a canister is?

Create a canister migration

Isn't enough for me to understand what is being added

[EsdrasVP]

@EsdrasVP can you add to the PR description what a canister is?

Create a canister migration

Isn't enough for me to understand what is being added

@agrare I updated the description explaining what a Canister is. Can you see if it's more understandable?

[agrare]

@EsdrasVP is Canister an industry standard term for this type of object? (A quick google search for "storage canister" yielded a lot of amazon results for air-tight coffee bean containers which might just be my recommended search results 😆)

If it has its own controller it almost sounds like a caniter is its own self-contained storage?

[EsdrasVP]

@EsdrasVP is Canister an industry standard term for this type of object? (A quick google search for "storage canister" yielded a lot of amazon results for air-tight coffee bean containers which might just be my recommended search results )

@agrare Other companies might call it by a different name, so I think that's why it's only appearing as coffee bean containers on search results hahaha.

If it has its own controller it almost sounds like a caniter is its own self-contained storage?

Yes, all the work will be done by the Canisters, which will exist inside of a PhysicalStorage. This distinction is important because a Lenovo PhysicalStorage will contain more than one Canister inside it.

[agrare]

Okay canister seems like a decent enough name don't want to dwell on that.

[agrare]

2 things here, can you add ems_ref for a unique reference? Even if e.g. position is unique for lenovo we can use ems_ref generally.
Also I assume this belongs to a physical_storage but you don't have a reference to physical_storage here.

[EsdrasVP]

@agrare I added now ems_ref and physical_storage_id to the migration.

[agrare]

This looks unrelated to the rest of this PR

[EsdrasVP]

@agrare It is, kinda. Because Canister will have some physical ports in it, and I didn't found any reference to this, so I created one. If you want to, I can put it in another PR.

[agrare]

Yeah lets do this in a new PR since port_status can apply to anything not just canisters. So a canister will have hardware -> guest_devices -> physical_network_ports?

[EsdrasVP]

So a canister will have hardware -> guest_devices -> physical_network_ports?

@agrare Exactly, this relationship it's currently on the core PR.

[EsdrasVP]

Yeah lets do this in a new PR since port_status can apply to anything not just canisters.

@agrare I've done it and put as dependency on this PR, could you take a look there?

[miq-bot]

Checked commit EsdrasVP@2c6bdd2 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. 🍪

[agrare]

@EsdrasVP should a physical_disk have a canister_id then?

[EsdrasVP]

@EsdrasVP should a physical_disk have a canister_id then?

@agrare No, because the PhysicalDisks are on the same level as Canisters on a PhysicalStorage. It's quite bad actually, because doesn't allow us to see which canister a disk is inside.