Save Physical Disks Model #17700
Merged
Save Physical Disks Model #17700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 13, 2018
Merged
EsdrasVP
force-pushed
the
save_storage_drive
branch
from
6351aba
to
4e4d8ef
Compare
EsdrasVP
force-pushed
the
save_storage_drive
branch
from
4e4d8ef
to
2260e6f
Compare
agrare
reviewed
Aug 10, 2018
app/models/physical_storage.rb
Outdated
| @@ -9,6 +9,8 @@ class PhysicalStorage < ApplicationRecord | |||
| has_one :asset_detail, :as => :resource, :dependent => :destroy, :inverse_of => false | |||
| has_many :guest_devices, :through => :hardware | |||
|
|
|||
| has_many :physical_disks, :dependent => :destroy, :inverse_of => false | |||
There was a problem hiding this comment.
@EsdrasVP why not specify :inverse_of => :physical_storage ?
There was a problem hiding this comment.
@agrare Changed here, I asked @CharlleDaniel about what exactly happens with a :inverse_of and he clarified me.
EsdrasVP
force-pushed
the
save_storage_drive
branch
from
2260e6f
to
9d8e755
Compare
|
Checked commit EsdrasVP@9d8e755 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
agrare
approved these changes
Aug 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is able to:
Depends on:
ManageIQ/manageiq-schema#233 - Merged