Model relation "SecurityGroup belongs to NetworkRouter or CloudSubnet" #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@agrare are you okay with this? |
|
Kindly ask either @Fryguy or @agrare to get this one in. Need to do a bunch of followup PRs, namely:
And would't want to get too close to code-freeze. |
|
@miha-plesko you don't need the parens for |
With this commit we add a foreign key on SecurityGroup to follow what Nuage needs. In Nuage, security group is something that only exists in a scope of either L3 domain (NetworkRouter) or L2 domain (CloudSubnet::L2). MIQ is currently not able to model such relation yet, hence this PR. Signed-off-by: Miha Pleško <miha.plesko@xlab.si>
miha-plesko
force-pushed
the
foreign-key-on-security-group
branch
from
3d80875 to
4bef54a
Compare
|
@agrare so no parens shall be. |
agrare
approved these changes
Aug 24, 2018
|
Checked commit miha-plesko@4bef54a with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 db/migrate/20180817152200_add_network_router_id_to_security_group.rb
db/migrate/20180817152201_add_cloud_subnet_id_to_security_group.rb
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this commit we add a foreign key on SecurityGroup to follow what Nuage needs. In Nuage, security group is something that only exists in a scope of either L3 domain (NetworkRouter) or L2 domain (CloudSubnet::L2).
MIQ is currently not able to model such relation yet, hence this PR.
@miq-bot add_label enhancement
@miq-bot assign @Fryguy
@Ladas @agrare looking forward to your opinion. Need for this was revealed when enhancing targeted refresh where we would need something like
network_router.security_groups, but there is no such relation yet... Is schema already frozen for Hammer?