Inform Rails that SecurityGroup now belongs to Router/Subnet #17900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@agrare please let me know if I should put |
|
@Ladas we don't usually provide rspecs for such foreign keys, right? |
|
@miha-plesko we should have the dependent nullify (it looks like it is missing in few places) We don't do specs for this, we should have specs in the refresh, for this relations. |
With this commit we inform Rails about two new foreign keys on :security_groups table: ```ruby security_group.cloud_subnet security_group.network_router cloud_subnet.security_groups network_router.security_groups ``` Signed-off-by: Miha Pleško <miha.plesko@xlab.si>
miha-plesko
force-pushed
the
sec-group-belongs-to-subnet-and-router
branch
from
3ee0e5b
to
fd18082
Compare
|
Thanks |
|
Checked commit miha-plesko@fd18082 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
agrare
approved these changes
Aug 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this commit we inform Rails about the two new foreign keys on
:security_groups table:Related schema PR: ManageIQ/manageiq-schema#258 (already merged)
@miq-bot add_label enhancement
@miq-bot assign @agrare