Rename applies_to_exp to visibility_expression #28
Conversation
|
@lpichler Cannot apply the following label because they are not recognized: gapridashvili |
| @@ -0,0 +1,5 @@ | |||
| class RenameAppliesToExpToMiqExpressionVisible < ActiveRecord::Migration[5.0] | |||
| def change | |||
| rename_column :custom_buttons, :applies_to_exp, :miq_expression_visible | |||
There was a problem hiding this comment.
visible in an adjective, so this reads funny to me. I'm thinking visibility_expression or visibility_miq_expression? Thoughts? Similar discussion in #29
There was a problem hiding this comment.
As in the other PR, I think visibility_<thing>, where thing is one of the common words we use to designate an expression is best 👍
lpichler
force-pushed
the
rename_applies_to_exp_to_miq_expression_visibily
branch
from
5800cfa
to
f25a9b3
Compare
lpichler
changed the title
lpichler
changed the title
lpichler
force-pushed
the
rename_applies_to_exp_to_miq_expression_visibily
branch
2 times, most recently
from
ac635cd
to
5bcc730
Compare
applies_to_exp is unused and we can use it for storing MiqExpression which can say whether the button will be displayed or not.
lpichler
force-pushed
the
rename_applies_to_exp_to_miq_expression_visibily
branch
from
5bcc730
to
679046a
Compare
|
Checked commit lpichler@679046a with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
I used |
|
I need to learn to read: ManageIQ/manageiq#15501 |
After renaming, rename also related column for serializing.
applies_to_expis unused and we can use it for storingMiqExpression which can say whether the button will be
displayed or not.
I think that it is better-named regard to feature but I am open for other ideas how to name it.
Links
https://www.pivotaltracker.com/n/projects/1608513/stories/147780727
cc @gtanzillo
@miq-bot assign @Fryguy
@miq-bot add_label gapridashvili