Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename applies_to_exp to visibility_expression for serializing #15501

Conversation

lpichler
Copy link
Contributor

@lpichler lpichler commented Jul 3, 2017

Follow-up of ManageIQ/manageiq-schema#28

After renaming, rename also related column for serializing.

@miq-bot assign @gtanzillo
@miq-bot add_label gapridashvili

@miq-bot
Copy link
Member

miq-bot commented Jul 3, 2017

@lpichler Cannot apply the following label because they are not recognized: gapridashvili

@Fryguy
Copy link
Member

Fryguy commented Jul 17, 2017

@lpichler I merged the corresponding migration, but I think this needs an update.

@Fryguy Fryguy closed this Jul 17, 2017
@Fryguy Fryguy reopened this Jul 17, 2017
@lpichler lpichler force-pushed the rename_applies_to_exp_to_miq_expression_visibily_for_serializing branch from 6f63233 to 86c043a Compare July 18, 2017 07:26
@lpichler lpichler changed the title Rename applies_to_exp to miq_expression_visibily for serializing Rename applies_to_exp to visibility_expression for serializing Jul 18, 2017
@lpichler lpichler force-pushed the rename_applies_to_exp_to_miq_expression_visibily_for_serializing branch 2 times, most recently from cd26869 to 331e1a0 Compare July 18, 2017 07:48
@lpichler lpichler closed this Jul 19, 2017
@lpichler lpichler reopened this Jul 19, 2017
@miq-bot
Copy link
Member

miq-bot commented Jul 21, 2017

This pull request is not mergeable. Please rebase and repush.

@gtanzillo
Copy link
Member

@lpichler Please resolve the conflict and I'll merge.

@lpichler lpichler force-pushed the rename_applies_to_exp_to_miq_expression_visibily_for_serializing branch from 331e1a0 to 533a33b Compare July 24, 2017 09:00
After renaming, rename also related column for serializing.
@lpichler lpichler force-pushed the rename_applies_to_exp_to_miq_expression_visibily_for_serializing branch from 533a33b to bf06a49 Compare July 24, 2017 09:18
@miq-bot
Copy link
Member

miq-bot commented Jul 24, 2017

Checked commit lpichler@bf06a49 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks fine. 🍪

Copy link
Member

@gtanzillo gtanzillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@gtanzillo gtanzillo added the core label Jul 25, 2017
@gtanzillo gtanzillo added this to the Sprint 66 Ending Aug 7, 2017 milestone Jul 25, 2017
@gtanzillo gtanzillo merged commit 0626660 into ManageIQ:master Jul 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants