Add Accessible to HostStorages #329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a property to the host storage mount information about if a particular datastore is accessible to the given host or not. If a datastore is inaccessible for some reason (e.g. the NFS server is down) then even though read_only may be false the datastore still cannot be accessed. VMware tracks this property in the HostMountInfo (where read_only is already pulled from) in a boolean field called "accessible" [0]. This can be used to ignore offline datastore for the purposes of provisioning as well as alerting the user of issues on their datastores [0] https://www.vmware.com/support/developer/vc-sdk/visdk41pubs/ApiReference/vim.host.MountInfo.html https://bugzilla.redhat.com/show_bug.cgi?id=1668020
|
Checked commit agrare@547d4af with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
This was referenced Jan 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a property to the host storage mount information about if a
particular datastore is accessible to the given host or not.
If a datastore is inaccessible for some reason (e.g. the NFS server is
down) then even though read_only may be false the datastore still cannot
be accessed.
VMware tracks this property in the HostMountInfo (where read_only is
already pulled from) in a boolean field called "accessible" [0].
This can be used to ignore offline datastore for the purposes of
provisioning as well as alerting the user of issues on their datastores
[0] https://www.vmware.com/support/developer/vc-sdk/visdk41pubs/ApiReference/vim.host.MountInfo.html
https://bugzilla.redhat.com/show_bug.cgi?id=1668020