-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Add price and currency cols to services #350
Conversation
@miq-bot add_label enhancement |
5278aed
to
92115a9
Compare
Checked commit d-m-u@92115a9 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
@d-m-u maybe it will be helpful: we have model
so I am asking if you want to use it and make relation between |
HI @lpichler, We haven't had to deal with prices/currency up until now. The use case is that we need to add a price and currency field during Service item creation to be displayed to the user at Catalog ordering time. Based on that, how should we proceed? |
I think @lpichler 's approach is probably best. That way we won't have to duplicate currency options. @tinaafitz is this just for display? Or are you going to integrate with chargeback at a more significant level? |
Thanks @carbonin. My understanding is that this is just for display purposes. |
Okay, then it's probably best to just use a reference to the existing, seeded, table rather than copying that effort. It will likely make things easier on the UI side as well. |
As part of an RFE that I ended up with, we need backend support to be able to save a price of catalog when adding a Catalog Item, aka a service. Since we have no way of storing that information on services at the moment, we need a price and a currency column.
The schema portion of https://bugzilla.redhat.com/show_bug.cgi?id=1602072