Add price to service templates.

[lfu]

Add columns for price and currency to service templates. So a service author can specify the price when creating a service template.

Part of ManageIQ/manageiq#18754
Related to #373

https://bugzilla.redhat.com/show_bug.cgi?id=1602072

@miq-bot add_label enhancement, hammer/no, changelog/yes

[miq-bot]

Checked commit lfu@1b13ad2 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. ⭐

[carbonin]

I have the same concerns here as I did with #350. And in fact you're referencing the same BZ ... @tinaafitz it looks like we resolved a direction to go in the previous PR I'm still pushing for that direction.

[carbonin]

Also, #350 was adding this to services while this PR is adding it to service_templates. Which is the correct place?

[carbonin]

Oh I see it's an add_reference now.

[carbonin]

Ah, excellent. Just took a look at the core PR. Sorry for the noise.

[carbonin]

I guess the question of which is the correct table is still out there though. @lfu why service_templates when @d-m-u was going to add it to services?

[lpichler]

I guess the question of which is the correct table is still out there though. @lfu why service_templates when @d-m-u was going to add it to services?

Not sure why but usually when anybody mention in BZ "Service" he most likely means Catalog Items or Catalog Bundle. (Service Templates)

there is mentioned path Service -> Catalog in UI, - so I think that Catalog Items or Catalog Bundle. (Service Templates) are correct here. Can you confirm it @lfu ?

[lpichler]

I think we should have chargeback_rate_detail_currency here - to see that it is related to chargeback_rate_detail_currencies table.

add_reference :service_templates, :chargeback_rate_detail_currency, :type => :bigint

you can specify foreign key in the model.

@carbonin @lfu what do you think ?

[carbonin]

I think the idea is to make the method #currency and the column currency_id so the relationship in the model specifies the class https://github.com/ManageIQ/manageiq/pull/18754/files#diff-9257fff45a7d1258305c9a6b7d15e322R66

[carbonin]

It's unfortunate that chargeback_rate_detail_currency isn't named just currencies because it doesn't look like the table has anything chargeback specific in it.

[lfu]

@carbonin Exactly what I am going to say.

[lpichler]

👍 👍

[Fryguy]

What is the effort to rename the table :)

[lfu]

A service author would create a service template (that can be a catalog item or catalog bundle) that users can order to get services. The relationship of service template and service is kind of like template and VM.