Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename table chargeback_rate_detail_currencies to currencies #421

Conversation

lpichler
Copy link
Contributor

@lpichler lpichler commented Oct 1, 2019

Currencies are not related just to chargeback

#367 (comment)

@miq-bot
Copy link
Member

miq-bot commented Oct 1, 2019

Checked commit lpichler@379a8c9 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 1 offense detected

db/migrate/20191001174700_rename_chargeback_rate_detail_currency_to_currency.rb

@lpichler lpichler changed the title [WIP] Rename table chargeback_rate_detail_currencies to currencies Rename table chargeback_rate_detail_currencies to currencies Oct 3, 2019
Copy link
Member

@kbrock kbrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@miq-bot miq-bot removed the wip label Oct 3, 2019
@d-m-u
Copy link
Contributor

d-m-u commented Nov 19, 2019

Does the replication exclude tables list need to change with this?

@carbonin carbonin merged commit 9df2ad0 into ManageIQ:master Nov 19, 2019
@carbonin carbonin added this to the Sprint 125 Ending Nov 25, 2019 milestone Nov 19, 2019
lpichler pushed a commit to lpichler/manageiq that referenced this pull request Nov 19, 2019
lpichler pushed a commit to lpichler/manageiq that referenced this pull request Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants