Rename: ChargebackRateDetailCurrency -> Currency #19538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpichler
force-pushed
the
rename_ChargebackRateDetailCurrencyToCurrency
branch
2 times, most recently
from
662965f
to
14f8d8b
Compare
|
@lpichler please create PR in https://github.com/ManageIQ/manageiq-cross_repo-tests. See this example |
Fryguy
reviewed
Nov 20, 2019
| ChargebackRate | ||
|
|
There was a problem hiding this comment.
This blank line was here intentionally, but I can't remember why I split the list 😆 ...can you leave it, and also keep Currency in the upper section?
lpichler
force-pushed
the
rename_ChargebackRateDetailCurrencyToCurrency
branch
3 times, most recently
from
c8b7e00
to
1787fcd
Compare
lpichler
changed the title
|
#19542 was merged. |
lpichler
force-pushed
the
rename_ChargebackRateDetailCurrencyToCurrency
branch
from
1787fcd
to
37bae1c
Compare
lpichler
force-pushed
the
rename_ChargebackRateDetailCurrencyToCurrency
branch
from
37bae1c
to
1a89817
Compare
lpichler
changed the title
lpichler
force-pushed
the
rename_ChargebackRateDetailCurrencyToCurrency
branch
from
1a89817
to
8137c73
Compare
|
Checked commit lpichler@8137c73 with ruby 2.5.5, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
|
this can be merged as ManageIQ/manageiq-cross_repo-tests#19 is not failing already (just one unrelated repo) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ChargebackRateDetail#chargeback_rate_detail_currency_id->ChargebackRateDetail#currency_idLinks
related (merged) PRs:
@miq-bot assign @kbrock
@miq-bot add_label technical debt