Add currency to service template. #18754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carbonin
reviewed
May 20, 2019
| @@ -63,6 +63,7 @@ class ServiceTemplate < ApplicationRecord | |||
|
|
|||
| belongs_to :service_template_catalog | |||
| belongs_to :zone | |||
| belongs_to :currency, :class_name => "ChargebackRateDetailCurrency", :inverse_of => false | |||
There was a problem hiding this comment.
What does the :inverse_of => false do here?
There was a problem hiding this comment.
Ah, @jrafanie found https://github.com/rails/rails/blob/5-0-stable/activerecord/lib/active_record/associations.rb#L704-L718 for me so it sounds like this is just telling AR that we're never going to ask for a currency's service templates which makes sense.
lfu
force-pushed
the
service_price_1602072
branch
from
a6d1ff6
to
85d94e1
Compare
lfu
force-pushed
the
service_price_1602072
branch
from
85d94e1
to
43bc02d
Compare
|
Checked commit lfu@43bc02d with ruby 2.3.3, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
carbonin
approved these changes
May 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add price and currency to service templates. So a service author can specify the price when creating a service template.
Part of ManageIQ/manageiq-schema#367.
https://bugzilla.redhat.com/show_bug.cgi?id=1602072
@miq-bot add_label enhancement, hammer/no, changelog/yes
@miq-bot assign @tinaafitz