Add DialogFieldAssociation table #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eclarizio
force-pushed
the
create_dialog_field_associations_table
branch
from
04f2a82 to
d0fef44
Compare
Fryguy
reviewed
Jul 17, 2017
| def change | ||
| create_table :dialog_field_associations, :id => false do |t| | ||
| t.integer "dialog_field_trigger_id", :null => false | ||
| t.integer "dialog_field_respond_id", :null => false |
There was a problem hiding this comment.
- Please use symbols for consistency.
- Please remove the :null => false.
- All tables must have an id for replication purposes, so remove the :id => false
eclarizio
force-pushed
the
create_dialog_field_associations_table
branch
from
d0fef44 to
90a1c9e
Compare
|
@Fryguy Fixed, thanks. |
eclarizio
force-pushed
the
create_dialog_field_associations_table
branch
from
90a1c9e to
191373b
Compare
|
@Fryguy I'm assuming the Rubocop issues are ignorable considering all the rest of the migrations are written similarly to how I wrote them, but please let me know if I need to fix those issues to get this merged. Thanks. |
eclarizio
force-pushed
the
create_dialog_field_associations_table
branch
from
191373b to
9eb1b33
Compare
|
Checked commit eclarizio@9eb1b33 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in preparation for the targeted auto-refresh enhancement. We will need dialog fields to be associated to one another.
Here is the corresponding main repo PR
https://www.pivotaltracker.com/story/show/148013179
@gmcculloug I don't know if you have merge rights on this repo but I figured I'd tag you anyway.