Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set up dialog_field relationships through DialogFieldAssociations #15566

Merged
merged 1 commit into from
Jul 28, 2017
Merged

Set up dialog_field relationships through DialogFieldAssociations #15566

merged 1 commit into from
Jul 28, 2017

Conversation

eclarizio
Copy link
Member

@eclarizio eclarizio commented Jul 13, 2017 •
edited
Loading

This will allow us to set up associations directly between dialog fields, which we will be using for the targeted auto refresh. There are two associations, dialog_field_trigger_associations and dialog_field_respond_associations. I (originally) went with the verbose name but I think just trigger_associations and respond_associations is fine too.

This PR requires a migration, which can be found here.

https://www.pivotaltracker.com/story/show/148838143

@miq-bot assign @gmcculloug

@eclarizio eclarizio mentioned this pull request Jul 13, 2017
Merged
@d-m-u d-m-u mentioned this pull request Jul 19, 2017
Merged
@eclarizio eclarizio force-pushed the add_dialog_field_associations branch from 5224026 to f95a9aa Compare July 21, 2017 15:15
@eclarizio
Copy link
Member Author

Tests are failing due to needed migration. Will need to be restarted after the migration PR gets merged.

@eclarizio eclarizio force-pushed the add_dialog_field_associations branch 2 times, most recently from f47861d to d9fb67b Compare July 24, 2017 16:30
@eclarizio eclarizio force-pushed the add_dialog_field_associations branch from d9fb67b to ce2c185 Compare July 25, 2017 15:55
@eclarizio
Copy link
Member Author

Updated with different association names. Instead of trigger_associations, this has been changed to dialog_field_responders, as it is specifically a list of dialog fields that are set to respond when the given dialog field triggers (which I realize seems confusing).

Similarly, respond_associations has been changed to dialog_field_triggers, which is a list of dialog fields that are currently set to trigger the given dialog field.

Hopefully that clears things up.

@miq-bot
Copy link
Member

miq-bot commented Jul 25, 2017

Checked commit eclarizio@ce2c185 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 0 offenses detected
Everything looks fine. 🍰

d-m-u
d-m-u suggested changes Jul 27, 2017
View reviewed changes
Copy link
Contributor

@d-m-u d-m-u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we name '''dialog_field.dialog_field_responders''' something less clunky?

@gmcculloug
Copy link
Member

@d-m-u I preferred this name as it makes it clearer that we are expecting dialog_field objects returned but I am open to hearing your suggestions.

d-m-u
d-m-u approved these changes Jul 27, 2017
View reviewed changes
Copy link
Contributor

@d-m-u d-m-u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@eclarizio
Copy link
Member Author

@gmcculloug Restarting travis should fix the specs now that the schema PR has been merged.

@gmcculloug gmcculloug merged commit 4f5e8f2 into ManageIQ:master Jul 28, 2017
@gmcculloug gmcculloug added this to the Sprint 66 Ending Aug 7, 2017 milestone Jul 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d-m-u d-m-u d-m-u approved these changes

Assignees

@gmcculloug gmcculloug

Labels
enhancement lifecycle/services
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eclarizio @miq-bot @gmcculloug @d-m-u