Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove MiqWidget with content_type set to rss #433

Merged
merged 1 commit into from
Nov 14, 2019

Conversation

ZitaNemeckova
Copy link
Contributor

@ZitaNemeckova ZitaNemeckova commented Nov 14, 2019

There's no code that handles them but they stayed in DB.

Removed in ManageIQ/manageiq-ui-classic#5271 and ManageIQ/manageiq#18478 .

@miq-bot add_label ivanchuk/no, technical debt

@lpichler please have a look, thanks :)

There's no code that handles them but they stayed in DB
@miq-bot
Copy link
Member

miq-bot commented Nov 14, 2019

@ZitaNemeckova unrecognized command 'ivanchuk', ignoring...

Accepted commands are: add_label, add_reviewer, assign, close_issue, move_issue, remove_label, rm_label, remove_reviewer, set_milestone

@miq-bot
Copy link
Member

miq-bot commented Nov 14, 2019

Checked commit ZitaNemeckova@230dde7 with ruby 2.5.5, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. ⭐

@ZitaNemeckova
Copy link
Contributor Author

@miq-bot add_label ivanchuk/no, technical debt

@carbonin carbonin self-assigned this Nov 14, 2019
@carbonin carbonin merged commit d5bb2bd into ManageIQ:master Nov 14, 2019
@carbonin carbonin added this to the Sprint 125 Ending Nov 25, 2019 milestone Nov 14, 2019
@ZitaNemeckova ZitaNemeckova deleted the remove_miqwidget_rss branch November 14, 2019 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants