Remove Timelines and RSS UI #5271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PanSpagetka
force-pushed
the
remove-timelines-and-rss
branch
from
6e2671f
to
7d85b05
Compare
|
@PanSpagetka what about removing |
|
This can be deleted too: |
|
@PanSpagetka isn't removing code fun! |
|
Checked commits PanSpagetka/manageiq-ui-classic@7d85b05~...13efb02 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@juliancheal YEAH (silently praying that I didn't break anything) |
|
LGTM 👍 |
|
FYI including the PR in my core PR ManageIQ/manageiq#18478 I don't get any of the UI test failures. I just have a couple of I have a feeling we'll have to merge these two PRs together. :) |
Merged
jrafanie
added a commit
to jrafanie/manageiq
that referenced
this pull request
Sep 10, 2024
;-) e9328983b3104 BugzID: 2678 Removed RSS feed for vms that fail basic policy, per *** git-svn-id: http://miq-ubuntusub.manageiq.com/svn/svnrepos/Manageiq/trunk@7851 3c68ef56-dcc3-11dc-9475-a42b84ecc76f Fixes ManageIQ#22778 Deprecated ManageIQ#18478 UI removed callers in ManageIQ/manageiq-ui-classic#5271
jrafanie
added a commit
to jrafanie/manageiq
that referenced
this pull request
Sep 10, 2024
Fixes ManageIQ#22778 Deprecated ManageIQ#18478 UI removed callers in ManageIQ/manageiq-ui-classic#5271
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SHOULD BE MERGED TOGETHER WITH ManageIQ/manageiq#18478
Removing Cloud Intel -> Timelines/RSS UI. Also removes RSS related code from widgets and other places which I am not sure that it should be removed.
@juliancheal please look at this and tell if some of the RSS code should stay ;)
@skateman
Links [Optional]
https://bugzilla.redhat.com/show_bug.cgi?id=1672933
Steps for Testing/QA [Optional]
There should be no Timelines/RSS options in menu.
I am not sure how to test widget RSS and other places where RSS might be.