Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user_id,group_id,tenant_id to MiqQueue #83

Merged
merged 2 commits into from
Oct 3, 2017

Conversation

mkanoor
Copy link
Contributor

@mkanoor mkanoor commented Oct 2, 2017

This is needed so that the Queue can run commands in the context of the user, group and tenant.

@mkanoor mkanoor force-pushed the add_identity_to_miq branch from 92dd842 to ad628bb Compare October 2, 2017 19:24
@mkanoor
Copy link
Contributor Author

mkanoor commented Oct 2, 2017

@bdunne @Fryguy
Please review

db/schema.yml Outdated
- type
- object_labels
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not happen.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe the migrations were run out of order?

@Fryguy
Copy link
Member

Fryguy commented Oct 2, 2017

@kbrock Please review.

@miq-bot
Copy link
Member

miq-bot commented Oct 2, 2017

Checked commits mkanoor/manageiq-schema@ad628bb~...3c70428 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks fine. 🍪

Copy link
Member

@kbrock kbrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we had unlimited time, sure would have liked to see these rpc/background calls get converted to events.

But yes, this is missing functionality in the queue. Automate currently does this manually. Will be nice to have this as a first class construct.

@Fryguy Fryguy merged commit d872c3a into ManageIQ:master Oct 3, 2017
@Fryguy Fryguy added this to the Sprint 71 Ending Oct 16, 2017 milestone Oct 3, 2017
@Fryguy Fryguy self-assigned this Oct 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants