Added user_id, group_id, tenant_id

[mkanoor]

If the User and group ids are passed in we run the method
using User.with_user which sets the User.current_user

When we execute object#methods via the Queue we loose the user context under which the method should run. When we execute methods for Generic Objects we need the user context, this PR would allow the user_id/group_id/tenant_id to be recorded in the Queue and set using User.with_user

Depends on Schema PR
ManageIQ/manageiq-schema#83

This PR is needed by these other PRs
#16077

[mkanoor]

The specs are failing because the schema changes have not been merged

[kbrock]

@mkanoor I'm not sure if we need more around setting the current group

I do see https://github.com/kbrock/manageiq/blob/master/lib/rbac/filterer.rb#L499

@jntullo @abellotti I remember thinking through a bunch of implications when we set the user.current_group in the api controller. But I couldn't find it. To be honest, I didn't look THAT hard. Could you point us to that logic, so we make sure that we use this logic when we pull items off of the queue?

oh and, ugh Timeout.timeout (We need it, but it also needed to be said)

[jntullo]

@kbrock not entirely sure I understand what you're looking for, because for the most part we aren't setting a user/group, which is what created the need for #16077 , where we can then set ae_user_identity on a generic object before calling the method

We are setting the userid here when creating the task, if this is what you mean

[Fryguy]

Merged the schema, so bouncing

[mkanoor]

@jntullo
We set the User.current_user based on the logged in user here https://github.com/ManageIQ/manageiq-api/blob/master/app/controllers/api/base_controller/authentication.rb#L22
This line sets the current group for the in memory user object.

So when the API makes the call into create generic task we can use

https://github.com/ManageIQ/manageiq-api/blob/eb172af56203e8f1747d98a17217d1d91ce715a9/app/controllers/api/base_controller/action.rb#L27

:user_id => User.current_user.id,
:group_id =>User.current_user.current_group.id,
:tenant_id => User.current_user.current_tenant.id

After this PR is merged

[kbrock]

@mkanoor thanks - you found it - It uses current_group_by_description= -- which ensures that the group (and therefore tenant) is valid for this user, with a special provision for super_user?.

Probably too complex for our needs here.

[miq-bot]

Checked commits mkanoor/manageiq@06cea72~...21404dc with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
4 files checked, 0 offenses detected
Everything looks fine. ⭐