Set current user for generic object methods #16120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jntullo unrecognized command 'enhancement', ignoring... Accepted commands are: add_label, assign, close_issue, move_issue, remove_label, rm_label, set_milestone |
|
👍 |
lfu
approved these changes
Oct 5, 2017
mkanoor
reviewed
Oct 5, 2017
spec/models/generic_object_spec.rb
Outdated
| describe 'property methods without user set' do | ||
| it 'will set the current user' do | ||
| workspace = double("MiqAeWorkspaceRuntime", :root => {"method_result" => "result"}) | ||
| User.current_user = user |
There was a problem hiding this comment.
@jntullo
Instead of setting the User.current_user could you use User.with_user_group(user, group) { spec commands }
akin to https://github.com/ManageIQ/manageiq/blob/master/spec/lib/rbac/filterer_spec.rb#L185
|
Checked commit jntullo@53faffd with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for ManageIQ/manageiq-api#93, follow up to #16089
This change allows setting of the current user so that the API has the ability to queue generic object methods and have them run successfully.
@miq-bot enhancement, automate
@miq-bot assign @mkanoor