Network provider: Refactor items to use API routes

[gildub]

The new practice is to use API routes instead of dedicated controllers methods for feeding Angular forms. We need to re-align the network items to make use of it.

• Network Router
• Cloud Network
• Cloud Subnet
• Security Groups
• Floating IPs

[gildub]

@h-kataria, could you please assign it to me?

[AparnaKarve]

@gildub The main idea here would be to get rid of controller routes and actions that feed a json to the angular form, and replace those actions in the angular controller with REST API calls.

To give you an example, in your most recent PR #716, network_router_networks_by_ems needs to go away.
On the angular side, you should call a suitable API using API.get and populate the form based on the output of this API. We already have a couple of angular controllers that use API.get that you can refer to get you started.

Can you try the following API and see if it gets you the output that you need to replace network_router_networks_by_ems?

/api/cloud_networks?expand=resources&filter[]=ems_id=<id>&attributes=name

*Replace the <id> with the correct id appropriately.

[gildub]

@AparnaKarve,

The /api/cloud_networks?expand=resources&filter[]=ems_id=<id>&attributes=name works, I'm able to retrieve all the networks filtered by the ems.

That's great, I can get started.

Meanwhile, my initial wonder was about the other network resources available from the web service end.
For instance api/cloud_subnets is not implemented which is consistent with /api/ :collection.

I suppose I have to submit a patch to manageiq core repo in order to add app/controllers/api_controller/cloud_subnets.rb and others related files.

[AparnaKarve]

I suppose I have to submit a patch to manageiq core repo in order to add app/controllers/api_controller/cloud_subnets.rb and others related files.

Yes, that is correct... and you'll find plenty of examples on how to add an API endpoint for a collection.
Also check out config/api.yml

[gildub]

The API provides for the resource for the Security Groups and related FW rules through the relationship.
The Cloud Subnet, Network Routers and Floating IPs don't have direct API resource.

[gildub]

Subnets need the REST API that was just added: ManageIQ/manageiq#15248

[miq-bot]

This issue has been automatically marked as stale because it has not been updated for at least 6 months.

If you can still reproduce this issue on the current release or on master, please reply with all of the information you have about it in order to keep the issue open.

Thank you for all your contributions!

[JPrause]

@gildub is this still a valid issue? If yes, lease remove the stale label. If not can you close.
If there's no update by next week, I'll be closing this issue.

[gildub]

@JPrause, no more need for it. Thanks.