Add cloud subnet REST API #15248
Add cloud subnet REST API #15248
Conversation
|
Skipping test [1] because it fails with undefined method `[]' for nil:NilClass # ./spec/support/api_helper.rb:112:in `action_identifier'
# ./spec/support/api_helper.rb:117:in `collection_action_identifier'
# ./spec/requests/api/collections_spec.rb:25:in `test_collection_bulk_query'
# ./spec/requests/api/collections_spec.rb:570:in `block (3 levels) in <top (required)>' |
|
@jntullo, could you please help with the failing test? |
| it "bulk query CloudSubnets" do | ||
| skip "collection_action_identifier gets undefined method `[]' for nil:NilClass" | ||
| FactoryGirl.create(:cloud_subnet) | ||
| test_collection_bulk_query(:could_subnets, cloud_subnets_url, CloudSubnet) |
There was a problem hiding this comment.
This test is failing because of a typo - s/could/cloud/
There was a problem hiding this comment.
@imtayadeway, thanks! 👍
|
@jntullo, don't worry about it :). |
|
Checked commit https://github.com/gildub/manageiq/commit/d63393e98cfbc0ed4e58ac1ad14836d10b2f5579 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 |
|
@gildub thanks for the enhancement, this LGTM!! @imtayadeway can you give a 👍 or approve if ok by you ? Thanks. |
|
@imtayadeway, thank you too! |
|
@gildub Is this PR supposed to be |
|
@simaishi, that's me, sorry I removed the miq-bot comment I used, which makes me realise how helpful it could be to trace back things, therefore I won't do it again. Anyway this is also needed by https://bugzilla.redhat.com/show_bug.cgi?id=1467725. |
|
@gildub ha ha.. thanks! I'm glad the source is identified 😄 So... this PR depends on ManageIQ/manageiq-ui-classic#1508, but it's currently marked as |
|
@simaishi, I don't see any restrictions for ManageIQ/manageiq-ui-classic#1508 to go to Fine (just replaced the fine label). Other similar PRs have made to Fine, the dependent pieces (new buttons, etc) have already been ported back. |
|
Backported to Fine via #16150 |
Need to be able to retrieve cloud subnets resources directly for ManageIQ/manageiq-providers-openstack#36
Depends upon ManageIQ/manageiq-ui-classic#1508