Network router gateway setup

[gildub]

The external gateway information wasn't fully handled.
Now external gateway values are correctly set up allowing to add reset ("clear") the gateway.

https://bugzilla.redhat.com/show_bug.cgi?id=1426268

Edit and Create share the same template:

[tzumainn]

👍 from a functionality perspective; calls the API correctly. Double-checking the code, this doesn't actually have any gem changes, correct?

[AparnaKarve]

@gildub I see that you have added a new controller route and action -- network_router_subnets_by_network

Currently we have a new practice in place for all our angular forms, which is --
Use REST API calls and avoid creating new controller actions/routes, especially true for any new functionality being added in the forms.

Hence I recommend using an API call here.

[AparnaKarve]

I checked that currently an API for network_routers does not exist, but it should not be too hard to add.

[AparnaKarve]

I missed the fact that this is an RFE BZ for 5.7... so maybe the REST API implementation can wait for now.
Can you create a follow-up PR later to call the REST API?

[gildub]

@AparnaKarve,

Ack to create PR for REST API, I created following issue as a tracker:
#737

Thanks

[AparnaKarve]

@gildub Thanks for creating the issue. We can work on this once this PR is merged.

[AparnaKarve]

Fields that are Required need to be explicitly shown as Required including the dropdowns below

[gildub]

@AparnaKarve , all the router gateway related field are optional

[AparnaKarve]

@gildub Some fields are Required, because otherwise the Add button will not light up (turn blue, that is) as seen in the screenshots below --

We need to clearly say Required for every Required field, it just makes for a better UX, that's all.

[gildub]

@AparnaKarve,

Oh sorry, yes the name is required and that one was removed by mistake, thanks

[AparnaKarve]

@tzumainn I think saving the Network Router record should be a queued operation (if it isn't already), otherwise the spinner might keep spinning indefinitely during a Save.

[tzumainn]

@AparnaKarve I think it's a Task - @gildub, is that correct?

I think optimally this makes it into the next 5.7 build, so if we can implement the REST API bit immediately after that would be great!

[dclarizio]

@gildub screen shots in the first comment would be appreciated 😄

[gildub]

@dclarizio, I added the screen shot, sorry I didn't have it in the first place, that was my intent but 'cause of Murphy's law I couldn't launch my instance anymore, Friday night, blah-blah :)

Please let me know if you think more information is required.

@AparnaKarve, please see my inline comment about API.

@tzumainn -Effectively no Gem added and using a task queue, nothing changed there.

Thanks

[miq-bot]

Checked commits https://github.com/gildub/manageiq-ui-classic/compare/679cb360fe7e7b8f180cef1a8e27532ac18b23f3~...7b2aff199a36f5975de953fbd0cf37a29e9a849c with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
3 files checked, 4 offenses detected

app/controllers/network_router_controller.rb

• ❗ - Line 480, Col 17 - Rails/DynamicFindBy - Use find_by instead of dynamic find_by_id_filtered.
• ❗ - Line 483, Col 18 - Rails/DynamicFindBy - Use find_by instead of dynamic find_by_id_filtered.
• ❗ - Line 500, Col 32 - Rails/DynamicFindBy - Use find_by instead of dynamic find_by_id_filtered.
• ❕ - Line 477, Col 3 - Metrics/AbcSize - Assignment Branch Condition size for form_external_gateway is too high. [20.32/20]

[AparnaKarve]

@gildub Thanks for addressing all the feedback!
@h-kataria This is good to go.

[simaishi]

@gildub There is a conflict backporting to Euwe. Please resolve conflict and create an Euwe-specific PR (referencing this one) or suggest other PRs to backport.

$ git status
On branch euwe
Your branch is up-to-date with 'origin/euwe'.
You are currently cherry-picking commit 741917e.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:

	new file:   app/views/network_router/_common_new_edit.haml
	modified:   app/views/network_router/add_interface_select.html.haml
	modified:   app/views/network_router/edit.html.haml
	modified:   app/views/network_router/new.html.haml
	modified:   app/views/network_router/remove_interface_select.html.haml
	modified:   config/routes.rb
	modified:   spec/controllers/network_router_controller_spec.rb

Unmerged paths:
  (use "git add <file>..." to mark resolution)

	both modified:   app/assets/javascripts/controllers/network_router/network_router_form_controller.js
	both modified:   app/controllers/network_router_controller.rb

[simaishi]

Backported to Euwe via ManageIQ/manageiq#14447 (Mar 27)