Improve UX for attaching Openstack cloud volumes to instances

[mansam]

This PR causes the Attach Volume to Instance form to only list volumes that are in an available state, and disables the Attach Volume to Instance button entirely when there are no volumes available to an instance. It also cleans up some tooltip wording for Detach to match other tooltips.

Ported over from ManageIQ/manageiq#13126

Links

• https://bugzilla.redhat.com/show_bug.cgi?id=1389446

[miq-bot]

Checked commits mansam/manageiq-ui-classic@321c64f~...04d224b with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1
6 files checked, 4 offenses detected

spec/helpers/application_helper/buttons/instance_attach_spec.rb

• ⚠️ - Line 16, Col 7 - Lint/UselessAssignment - Useless assignment to variable - volume.
• ⚠️ - Line 27, Col 7 - Lint/UselessAssignment - Useless assignment to variable - volume.
• ⚠️ - Line 37, Col 7 - Lint/UselessAssignment - Useless assignment to variable - volume.
• ⚠️ - Line 7, Col 7 - Lint/UselessAssignment - Useless assignment to variable - volume.

[tzumainn]

@miq-bot add_label euwe/yes
@miq-bot add_label blocker
@miq-bot add_label bug

[simaishi]

Euwe backkport conflict:

$ git cherry-pick -x -e -m 1 -Xsubtree=/ ac675e7
error: could not apply ac675e7... Merge pull request #110 from mansam/only-list-cloud-volumes-that-are-available-to-attach

$ git diff
diff --cc app/helpers/application_helper/button/instance_detach.rb
index cb83ac0,cd7fce1..0000000
--- a/app/helpers/application_helper/button/instance_detach.rb
+++ b/app/helpers/application_helper/button/instance_detach.rb
@@@ -1,16 -1,8 +1,22 @@@
  class ApplicationHelper::Button::InstanceDetach < ApplicationHelper::Button::Basic
++<<<<<<< HEAD
 +  def calculate_properties
 +    super
 +    if @record.number_of(:cloud_volumes) == 0
 +      self[:title] = _("%{model} \"%{name}\" has no attached %{volumes}") % {
 +        :model   => ui_lookup(:table => 'vm_cloud'),
 +        :name    => @record.name,
 +        :volumes => ui_lookup(:tables => 'cloud_volumes')
 +      }
++=======
+   def disabled?
+     if @record.number_of(:cloud_volumes).zero?
+       @error_message = _("This Instance has no attached Cloud Volumes.")
++>>>>>>> ac675e7... Merge pull request #110 from mansam/only-list-cloud-volumes-that-are-available-to-attach
      end
 -    @error_message.present?
 +  end
 +
 +  def disabled?
 +    @record.number_of(:cloud_volumes) == 0
    end
  end

[simaishi]

@mansam Please resolve conflict and make Euwe-specific PR (referencing this one) or suggest other PRs to backport.

[mansam]

@simaishi ManageIQ/manageiq#13437 should do the job.

[simaishi]

Backported to Euwe via ManageIQ/manageiq#13437