Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tenant to openstack instance factory so that tests match reality #13413

Conversation

mansam
Copy link
Contributor

@mansam mansam commented Jan 9, 2017

This patch causes Openstack VM fixtures to belong to a Cloud Tenant by default in order to better match reality. This is necessary for the tests in ManageIQ/manageiq-ui-classic#110 to pass.

https://bugzilla.redhat.com/show_bug.cgi?id=1389446

@miq-bot
Copy link
Member

miq-bot commented Jan 9, 2017

Checked commit mansam@e8493a0 with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1
1 file checked, 0 offenses detected
Everything looks good. ⭐

@tzumainn
Copy link
Contributor

@miq-bot add_label euwe/yes
@miq-bot add_label blocker
@miq-bot add_label bug

@tzumainn
Copy link
Contributor

👍 Looks good to me

@blomquisg blomquisg merged commit 83c7c6a into ManageIQ:master Jan 10, 2017
@blomquisg blomquisg added this to the Sprint 52 Ending Jan 16, 2017 milestone Jan 10, 2017
@mansam
Copy link
Contributor Author

mansam commented Jan 16, 2017

simaishi pushed a commit that referenced this pull request Jan 16, 2017
…e-cloud-tenant

Add tenant to openstack instance factory so that tests match reality
(cherry picked from commit 83c7c6a)

https://bugzilla.redhat.com/show_bug.cgi?id=1413695
@simaishi
Copy link
Contributor

Euwe backport details:

$ git log -1
commit 62c06f227866a01aba4954d01577c93d19217b16
Author: Greg Blomquist <blomquisg@gmail.com>
Date:   Tue Jan 10 15:38:43 2017 -0500

    Merge pull request #13413 from mansam/openstack-vm-factory-should-have-cloud-tenant
    
    Add tenant to openstack instance factory so that tests match reality
    (cherry picked from commit 83c7c6ad0d4cae9399bab6e43da7767e4bac706c)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1413695

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants