Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edit method name in spec for Cloud Subnet #1347

Closed
wants to merge 1 commit into from
Closed

Edit method name in spec for Cloud Subnet #1347

wants to merge 1 commit into from

Conversation

andyvesel
Copy link
Contributor

In ManageIQ/manageiq#15087 there were delete and raw_delete methods added for Cloud Subnet.
Here's the method name changed in spec file from raw_delete_cloud_subnet to delete_cloud_subnet.

@miq-bot
Copy link
Member

miq-bot commented May 15, 2017

Checked commit andyvesel@9760ec9 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks fine. 🍪

@dclarizio
Copy link

@andyvesel spec test is failing

@andyvesel andyvesel closed this May 18, 2017
@andyvesel andyvesel reopened this May 18, 2017
@himdel
Copy link
Contributor

himdel commented May 19, 2017

Guessing this should be pending core, pending a manageiq-providers-openstack PR that fixes that call in app/models/manageiq/providers/openstack/network_manager/cloud_subnet.rb?

@andyvesel andyvesel mentioned this pull request May 22, 2017
Closed
@andyvesel
Copy link
Contributor Author

Since we decided to keep raw methods in OpenStack-specific classes, there's no need to change this spec.
Closing.
See details on ManageIQ/manageiq#15087 and ManageIQ/manageiq-providers-openstack#40

@andyvesel andyvesel closed this Jun 20, 2017
@andyvesel andyvesel deleted the edit_spec_for_cloud_subnet branch June 20, 2017 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mzazrivec mzazrivec

Labels
compute/cloud pending core test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@andyvesel @miq-bot @dclarizio @himdel @mzazrivec