Add delete method for Cloud Subnet

[andyvesel]

Add delete and raw_delete methods for Cloud Subnet model in order to expose delete operations in Automate engine: ManageIQ/manageiq-automation_engine#9

[gmcculloug]

This should be raw_delete_cloud_subnet

[andyvesel]

Fixed

[gmcculloug]

@andyvesel Along with my comment about the method name, I am seeing two places were the raw_ method is called directly and should be changed to use the delete_cloud_subnet method.

https://github.com/ManageIQ/manageiq-providers-openstack/blob/master/app/models/manageiq/providers/openstack/network_manager/cloud_subnet.rb#L49
and
https://github.com/ManageIQ/manageiq-ui-classic/blob/master/spec/controllers/cloud_subnet_controller_spec.rb#L188

[miq-bot]

Checked commit andyvesel@c0d8975 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks fine. 👍

[andyvesel]

@gmcculloug in this case I have to create two separate PRs in Openstack and UI repos, correct?

[gmcculloug]

@andyvesel Correct. Thanks for helping get this cleaned up.

[andyvesel]

@gmcculloug not a problem :)

[gmcculloug]

@andyvesel Any reason to keep the wip label? Is there any BZ related to this work or is it all meant for upstream?

[andyvesel]

@gmcculloug actually no big reason and we've no BZ for this.
I usually using WIP, when I'm not sure if everything's right in a PR. But if it's not a necessary thing, I remove it.

[gildub]

@gmcculloug,

Regarding ManageIQ/manageiq-providers-openstack#40,
the practice has been, so far, to wrap raw calls using raw_ prefixed method. I believe we need to be consistent and such a change need to be submitted to @ALL.

@martinpovolny (among others) can confirm above as well.

Thanks.