Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add evaluation of enablement expression and displayed text to custom button #1828

Merged
merged 6 commits into from
Aug 10, 2017

Conversation

lpichler
Copy link
Contributor

@lpichler lpichler commented Aug 4, 2017

enable custom buttons according to the evaluation of enablement expression and display disabled_text if the button is a disabled
disabled button:
enabled custom button

on the list:

  • if all enablement expressions are not set then custom buttons are enabled (as it was before)
  • if any enablement expression is evaluated to false then whole group button is disabled

Links

backend ManageIQ/manageiq#15729

@miq-bot assign @martinpovolny

@miq-bot miq-bot added the wip label Aug 4, 2017
@lpichler lpichler force-pushed the evaluate_enablement_expression branch from 64a1c16 to 983ff26 Compare August 8, 2017 07:42
@lpichler lpichler changed the title [WIP] Add evaluation of enablement expression and displayed text to custom button Add evaluation of enablement expression and displayed text to custom button Aug 8, 2017
@lpichler
Copy link
Contributor Author

lpichler commented Aug 8, 2017

ManageIQ/manageiq#15729 was merged

@miq-bot miq-bot removed the wip label Aug 8, 2017
@martinpovolny
Copy link
Member

The code looks good, but the travis failure seems legit. Please, take a look.

@miq-bot
Copy link
Member

miq-bot commented Aug 9, 2017

This pull request is not mergeable. Please rebase and repush.

@lpichler lpichler force-pushed the evaluate_enablement_expression branch from fb3feef to 616cae4 Compare August 9, 2017 13:28
@miq-bot
Copy link
Member

miq-bot commented Aug 9, 2017

Checked commits lpichler/manageiq-ui-classic@895b348~...616cae4 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 2 offenses detected

app/helpers/application_helper/toolbar_builder.rb

@mzazrivec mzazrivec self-assigned this Aug 10, 2017
@mzazrivec mzazrivec added this to the Sprint 67 Ending Aug 21, 2017 milestone Aug 10, 2017
@mzazrivec mzazrivec merged commit 86fb69d into ManageIQ:master Aug 10, 2017
@lpichler lpichler deleted the evaluate_enablement_expression branch August 10, 2017 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants