Add evaluation of enablement expression and displayed text to custom button #1828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpichler
force-pushed
the
evaluate_enablement_expression
branch
from
64a1c16
to
983ff26
Compare
lpichler
changed the title
|
ManageIQ/manageiq#15729 was merged |
|
The code looks good, but the travis failure seems legit. Please, take a look. |
|
This pull request is not mergeable. Please rebase and repush. |
lpichler
force-pushed
the
evaluate_enablement_expression
branch
from
0579a45
to
fb3feef
Compare
to be able use it in UI buttons
parameter options was used for enabling custom buttons by parameter but now it will be controlled by expression
lpichler
force-pushed
the
evaluate_enablement_expression
branch
from
fb3feef
to
616cae4
Compare
|
Checked commits lpichler/manageiq-ui-classic@895b348~...616cae4 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 app/helpers/application_helper/toolbar_builder.rb
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
enable custom buttons according to the evaluation of enablement expression and display disabled_text if the button is a disabled
disabled button:
on the list:
Links
backend ManageIQ/manageiq#15729
@miq-bot assign @martinpovolny