Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Evaluate enablement expressions for custom buttons #15729

Merged
merged 2 commits into from
Aug 8, 2017
Merged

Evaluate enablement expressions for custom buttons #15729

merged 2 commits into from
Aug 8, 2017

Conversation

lpichler
Copy link
Contributor

@lpichler lpichler commented Aug 3, 2017

this method will be used in UI to evaluate enablement expression for the button:

  • if enablement expression is not set then the method is evaluated as true
  • if enablement expression is set then the method returns the result of expression evaluation
  • if enablement expression is set and method is called for the list then the expression is evaluated as false

Links

https://www.pivotaltracker.com/story/show/147780767

@lpichler
Copy link
Contributor Author

lpichler commented Aug 3, 2017

@miq-bot add_label enhancement
@miq-bot assign @gtanzillo

cc @martinpovolny

@miq-bot
Copy link
Member

miq-bot commented Aug 3, 2017

Checked commits lpichler/manageiq@77f10e4~...0783236 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 0 offenses detected
Everything looks fine. 🍰

@lpichler lpichler mentioned this pull request Aug 4, 2017
Merged
gtanzillo
gtanzillo approved these changes Aug 8, 2017
View reviewed changes
Copy link
Member

@gtanzillo gtanzillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@gtanzillo gtanzillo added this to the Sprint 66 Ending Aug 7, 2017 milestone Aug 8, 2017
@gtanzillo gtanzillo merged commit fc55e59 into ManageIQ:master Aug 8, 2017
@lpichler lpichler deleted the evaluate_enabledment_expressions_for_buttons branch August 8, 2017 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gtanzillo gtanzillo gtanzillo approved these changes

Assignees

@gtanzillo gtanzillo

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lpichler @miq-bot @gtanzillo