Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add list of roles to rbac #271

Merged
merged 3 commits into from
Feb 1, 2017
Merged

Add list of roles to rbac #271

merged 3 commits into from
Feb 1, 2017

Conversation

lpichler
Copy link
Contributor

@lpichler lpichler commented Jan 30, 2017 •
edited by miq-bot
Loading

fixes #135
backend PR required ManageIQ/manageiq#13689

add list of role to rbac:

  • in group form
  • check role when form of group is stored
  • in list of role in tree

cc @gtanzillo

@miq-bot assign @martinpovolny

@lpichler
Copy link
Contributor Author

@miq-bot add_label backend/pending

@miq-bot
Copy link
Member

miq-bot commented Jan 30, 2017

@lpichler Cannot apply the following label because they are not recognized: backend/pending

@miq-bot
Copy link
Member

miq-bot commented Jan 30, 2017

Checked commits lpichler/manageiq-ui-classic@f916dff~...d9d1ddd with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
2 files checked, 0 offenses detected
Everything looks good. 🏆

@martinpovolny martinpovolny added this to the Sprint 54 Ending Feb 13, 2017 milestone Feb 1, 2017
@martinpovolny martinpovolny merged commit 71d9078 into ManageIQ:master Feb 1, 2017
@lpichler lpichler deleted the add_list_of_roles_to_rbac branch February 1, 2017 10:54
@martinpovolny martinpovolny mentioned this pull request Feb 3, 2017
Merged
@martinpovolny
Copy link
Member

martinpovolny commented Feb 3, 2017 •
edited
Loading

Follow-up for #296.

gtanzillo
gtanzillo reviewed Feb 3, 2017
View reviewed changes
Copy link
Member

@gtanzillo gtanzillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@martinpovolny
Copy link
Member

https://bugzilla.redhat.com/show_bug.cgi?id=1418662

@lpichler
Copy link
Contributor Author

lpichler commented Feb 9, 2017

EUWE BZ https://bugzilla.redhat.com/show_bug.cgi?id=1419686

@simaishi

@miq-bot
Copy link
Member

miq-bot commented Feb 9, 2017

@lpichler Cannot apply the following label because they are not recognized: backend/pending

@simaishi
Copy link
Contributor

simaishi commented Feb 9, 2017 •
edited
Loading

Euwe backport (to manageiq repo)details:

$ git log -1
commit 19c1aae0ce28f9f7fe458367512234e05b4d4837
Author: Martin Povolny <mpovolny@redhat.com>
Date:   Wed Feb 1 11:25:33 2017 +0100

    Merge pull request #271 from lpichler/add_list_of_roles_to_rbac
    
    Add list of roles to rbac
    (cherry picked from commit 71d9078d24a73fce37a5b91f4dbfd698f7c24858)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1419686

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gtanzillo gtanzillo gtanzillo left review comments

Assignees

@martinpovolny martinpovolny

Labels
blocker bug euwe/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

A tenant admin can create a user with role EvmRole-super_administrator
5 participants
@lpichler @miq-bot @martinpovolny @simaishi @gtanzillo