Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix assigning roles in group form #296

Merged
merged 2 commits into from
Feb 3, 2017

Conversation

lpichler
Copy link
Contributor

@lpichler lpichler commented Feb 3, 2017

Rbac.filtered doesn't accept integer there is Rbac.filtered_object for this purposes.

Reproducer
edit any Group in access control
change role and
it is causing error:

[----] F, [2017-02-03T09:17:17.212149 #74779:3fd82712598c] FATAL -- : Error caught: [NoMethodError] undefined method `all' for 1000000000009:Fixnum
/Users/liborpichler/manageiq/manageiq/lib/rbac/filterer.rb:209:in `search'
/Users/liborpichler/manageiq/manageiq/lib/rbac/filterer.rb:112:in `search'
/Users/liborpichler/manageiq/manageiq/lib/rbac.rb:3:in `search'
/Users/liborpichler/manageiq/manageiq/lib/rbac/filterer.rb:280:in `filtered'
/Users/liborpichler/manageiq/manageiq/lib/rbac/filterer.rb:116:in `filtered'
/Users/liborpichler/manageiq/manageiq-ui-classic/app/controllers/ops_controller/ops_rbac.rb:1035:in `valid_role?'
/Users/liborpichler/manageiq/manageiq-ui-classic/app/controllers/ops_controller/ops_rbac.rb:1048:in `rbac_group_get_form_vars'
/Users/liborpichler/manageiq/manageiq-ui-classic/app/controllers/ops_controller/ops_rbac.rb:796:in `rbac_field_changed'
/Users/liborpichler/manageiq/manageiq-ui-classic/app/controllers/ops_controller/ops_rbac.rb:254:in `rbac_group_field_changed'

cc @mzazrivec
@miq-bot add_label ui, bug

@miq-bot assign @martinpovolny

@miq-bot
Copy link
Member

miq-bot commented Feb 3, 2017

Checked commits lpichler/manageiq-ui-classic@38d428d~...2240de9 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
1 file checked, 0 offenses detected
Everything looks good. 🍰

@martinpovolny martinpovolny merged commit 40f8a76 into ManageIQ:master Feb 3, 2017
@martinpovolny martinpovolny added this to the Sprint 54 Ending Feb 13, 2017 milestone Feb 3, 2017
@martinpovolny
Copy link
Member

To be backported together with #271.

@martinpovolny
Copy link
Member

@lpichler lpichler deleted the fix_assigning_roles branch February 3, 2017 17:50
@lpichler
Copy link
Contributor Author

lpichler commented Feb 9, 2017

@simaishi this is part of
EUWE BZ https://bugzilla.redhat.com/show_bug.cgi?id=1419686

@simaishi
Copy link
Contributor

simaishi commented Feb 9, 2017

Euwe backport (to manageiq repo) details:

$ git log -1
commit f291f3c9da6682504e25bfba3744e8b10cd33a00
Author: Martin Povolny <mpovolny@redhat.com>
Date:   Fri Feb 3 16:46:32 2017 +0100

    Merge pull request #296 from lpichler/fix_assigning_roles
    
    Fix assigning roles in group form
    (cherry picked from commit 40f8a76205f7b6cac2a0cfd9c97a6a141623552a)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1419686

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants