Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary stub #3582

Merged
merged 2 commits into from
Mar 14, 2018
Merged

Remove unnecessary stub #3582

merged 2 commits into from
Mar 14, 2018

Conversation

bdunne
Copy link
Member

@bdunne bdunne commented Mar 12, 2018

Depends on: ManageIQ/manageiq#17139
Based on changes in: #3568

  • Prefer the IANA reserved domains
  • Remove stub for MiqServer.my_server

@bdunne
Copy link
Member Author

bdunne commented Mar 12, 2018

@miq-bot add_reviewer @h-kataria

cc @jrafanie since he enjoyed the amount of effort I went through trying to delete this one line. 😄

@miq-bot miq-bot requested a review from h-kataria March 12, 2018 21:51
@miq-bot
Copy link
Member

miq-bot commented Mar 12, 2018

Checked commits bdunne/manageiq-ui-classic@9b09cfc~...8714b32 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 👍

controller.send(:zone_save_ntp_server_settings, zone)
allow(MiqServer).to receive(:my_server).and_return(miq_server)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All that for this line... 😆

Copy link
Member

@jrafanie jrafanie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@mzazrivec mzazrivec self-assigned this Mar 14, 2018
@mzazrivec mzazrivec added this to the Sprint 82 Ending Mar 26, 2018 milestone Mar 14, 2018
@mzazrivec mzazrivec merged commit a32d655 into ManageIQ:master Mar 14, 2018
@bdunne bdunne deleted the unnecessary_stub branch March 14, 2018 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants