-
Notifications
You must be signed in to change notification settings - Fork 898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only update zone if found #17139
Only update zone if found #17139
Conversation
Checked commits bdunne/manageiq@805ac43~...8d67d12 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥇 👍
@miq-bot add_label gaprindashvili/yes It appears that this PR should fix this blocker bz https://bugzilla.redhat.com/show_bug.cgi?id=1595158 |
@miq-bot add_label blocker |
Only update zone if found (cherry picked from commit 360af51) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1599349
Gaprindashvili backport details:
|
In trying to remove an unnecessary stub from a test, I found that the zone was unexpectedly being removed from the server. It turns out that the settings reload was trying to set the zone to the default zone since the default config has
:server => {:zone => "default"}
. I only found this because it was the test environment and I didn't have a "default" zone. If someone enters something invalid in this section of the config they would also have the same problem.I'll link PR's for:
BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1595158