Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only update zone if found #17139

Merged
merged 2 commits into from
Mar 13, 2018
Merged

Conversation

bdunne
Copy link
Member

@bdunne bdunne commented Mar 12, 2018

In trying to remove an unnecessary stub from a test, I found that the zone was unexpectedly being removed from the server. It turns out that the settings reload was trying to set the zone to the default zone since the default config has :server => {:zone => "default"}. I only found this because it was the test environment and I didn't have a "default" zone. If someone enters something invalid in this section of the config they would also have the same problem.

I'll link PR's for:

BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1595158

@miq-bot
Copy link
Member

miq-bot commented Mar 12, 2018

Checked commits bdunne/manageiq@805ac43~...8d67d12 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. ⭐

@chrisarcand chrisarcand merged commit 360af51 into ManageIQ:master Mar 13, 2018
@chrisarcand chrisarcand self-assigned this Mar 13, 2018
@chrisarcand chrisarcand added this to the Sprint 81 Ending Mar 12, 2018 milestone Mar 13, 2018
@bdunne bdunne deleted the only_update_zone_if_found branch March 13, 2018 11:19
Copy link
Member

@jrafanie jrafanie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇 👍

@juliancheal
Copy link
Member

@miq-bot add_label gaprindashvili/yes

It appears that this PR should fix this blocker bz https://bugzilla.redhat.com/show_bug.cgi?id=1595158

@JPrause
Copy link
Member

JPrause commented Jul 5, 2018

@miq-bot add_label blocker

@miq-bot miq-bot added the blocker label Jul 5, 2018
simaishi pushed a commit that referenced this pull request Jul 11, 2018
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit fbb84f082699e1e6ede42aa25e372bf265ab2218
Author: Chris Arcand <chrisarcand@users.noreply.github.com>
Date:   Mon Mar 12 20:16:47 2018 -0500

    Merge pull request #17139 from bdunne/only_update_zone_if_found
    
    Only update zone if found
    (cherry picked from commit 360af512f8c2bfbdc0c3478715805f2e19fdf68d)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1599349

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants