-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable WebMKS console access for VMware vCloud's VMs #3679
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I need to test and think about this a little bit, but looks good 👍
N_('Access'), | ||
:items => [ | ||
button( | ||
:vm_webmks_console, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you dropping the cockpit_console
intentionally here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. It was never implemented, only the button was here (always disabled). I guess it was a copy-paste when adding vCloud provider. Best to remove it now and add later should it be needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay for me, but I'd do a separate commit 😉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, I've left the cock
pit in code and only added TODO to remove it.
c401f89
to
e1b7274
Compare
:items => [ | ||
# TODO: remove cockpit button because backend isn't implemented yet. | ||
button( | ||
:cockpit_console, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The order of the buttons here should be consistent with the other screens. So VM console
first and Web Console
as the second.
With this commit we bring button "Access -> VM Console" to life. We're able to reuse many good stuff from Vmware:.InfraManager, but there are also some vCloud specifics. Namely, the JavaScript SDK needs to be initialized with two extra parameters: ``` VCDProxyHandshakeVmxPath // vmx path of the vm (obtained as part of mks ticket) enableUint8Utf8 // only uint8utf8 protocol works so we need to enable it ``` Signed-off-by: Miha Pleško <miha.plesko@xlab.si>
e1b7274
to
ea0a5fe
Compare
Checked commit miha-plesko@ea0a5fe with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mzazrivec I think this should've been |
Gaprindashvili backport details:
|
Enable WebMKS console access for VMware vCloud's VMs (cherry picked from commit a63c355) https://bugzilla.redhat.com/show_bug.cgi?id=1563364
With this commit we bring button "Access -> VM Console" to life. We're able to reuse many good stuff from
Vmware:.InfraManager
, but there are also some vCloud specifics. Namely, the JavaScript SDK needs to be initialized with two extra parameters:BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1560517
Video: http://x.k00.fr/console
@miq-bot add_label enhancement,gaprindashvili/yes
@miq-bot assign @mzazrivec
Related PRs:
ManageIQ/manageiq#17200
ManageIQ/manageiq-providers-vmware#218
/cc @bmclaughlin @gberginc