Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable WebMKS console access for VMware vCloud's VMs #3679

Merged
merged 1 commit into from
Apr 3, 2018
Merged

Enable WebMKS console access for VMware vCloud's VMs #3679

merged 1 commit into from
Apr 3, 2018

Conversation

miha-plesko
Copy link
Contributor

@miha-plesko miha-plesko commented Mar 26, 2018 •
edited
Loading

With this commit we bring button "Access -> VM Console" to life. We're able to reuse many good stuff from Vmware:.InfraManager, but there are also some vCloud specifics. Namely, the JavaScript SDK needs to be initialized with two extra parameters:

VCDProxyHandshakeVmxPath // vmx path of the vm (obtained as part of mks ticket)
enableUint8Utf8          // only uint8utf8 protocol works so we need to enable it

capture

BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1560517
Video: http://x.k00.fr/console

@miq-bot add_label enhancement,gaprindashvili/yes
@miq-bot assign @mzazrivec

Related PRs:
ManageIQ/manageiq#17200
ManageIQ/manageiq-providers-vmware#218

/cc @bmclaughlin @gberginc

This was referenced Mar 26, 2018
Merged
Merged
@mzazrivec mzazrivec requested a review from skateman March 26, 2018 13:24
skateman
skateman reviewed Mar 26, 2018
View reviewed changes
Copy link
Member

@skateman skateman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to test and think about this a little bit, but looks good 👍

app/helpers/application_helper/toolbar/x_vm_cloud_center.rb Outdated
N_('Access'),
:items => [
button(
:vm_webmks_console,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you dropping the cockpit_console intentionally here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. It was never implemented, only the button was here (always disabled). I guess it was a copy-paste when adding vCloud provider. Best to remove it now and add later should it be needed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay for me, but I'd do a separate commit 😉

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, I've left the cock
pit in code and only added TODO to remove it.

@miha-plesko miha-plesko force-pushed the vcloud-webmks branch 3 times, most recently from c401f89 to e1b7274 Compare March 29, 2018 07:48
skateman
skateman reviewed Mar 29, 2018
View reviewed changes
app/helpers/application_helper/toolbar/x_vm_cloud_center.rb Outdated
:items => [
# TODO: remove cockpit button because backend isn't implemented yet.
button(
:cockpit_console,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The order of the buttons here should be consistent with the other screens. So VM console first and Web Console as the second.

@miha-plesko
Enable WebMKS console access for VMware vCloud's VMs
ea0a5fe 
With this commit we bring button "Access -> VM Console" to life. We're
able to reuse many good stuff from Vmware:.InfraManager, but there are
also some vCloud specifics. Namely, the JavaScript SDK needs to be
initialized with two extra parameters:

```
VCDProxyHandshakeVmxPath // vmx path of the vm (obtained as part of mks ticket)
enableUint8Utf8          // only uint8utf8 protocol works so we need to enable it
```

Signed-off-by: Miha Pleško <miha.plesko@xlab.si>
@miq-bot
Copy link
Member

miq-bot commented Mar 29, 2018

Checked commit miha-plesko@ea0a5fe with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
5 files checked, 0 offenses detected
Everything looks fine. ⭐

skateman
skateman approved these changes Mar 30, 2018
View reviewed changes
Copy link
Member

@skateman skateman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Seal of Approval
Good to go if the core PR gets merged 👍

@mzazrivec mzazrivec added this to the Sprint 83 Ending Apr 9, 2018 milestone Apr 3, 2018
@mzazrivec mzazrivec merged commit a63c355 into ManageIQ:master Apr 3, 2018
@skateman
Copy link
Member

skateman commented Apr 3, 2018

@mzazrivec I think this should've been pending core ...

@simaishi
Copy link
Contributor

simaishi commented Apr 3, 2018

Gaprindashvili backport details:

$ git log -1
commit 10fb920fc3ce3ad1da3293a7ed1751d4c178d408
Author: Milan Zázrivec <mzazrivec@redhat.com>
Date:   Tue Apr 3 08:25:06 2018 +0200

    Merge pull request #3679 from miha-plesko/vcloud-webmks
    
    Enable WebMKS console access for VMware vCloud's VMs
    (cherry picked from commit a63c3559bb12ea6057dc254864692c8da3d5c3e3)
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1563364

simaishi pushed a commit that referenced this pull request Apr 9, 2018
@mzazrivec @simaishi
Merge pull request #3679 from miha-plesko/vcloud-webmks
7d87363 
Enable WebMKS console access for VMware vCloud's VMs
(cherry picked from commit a63c355)

https://bugzilla.redhat.com/show_bug.cgi?id=1563364
@miha-plesko miha-plesko deleted the vcloud-webmks branch January 7, 2019 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skateman skateman skateman approved these changes

Assignees

@mzazrivec mzazrivec

Labels
enhancement gaprindashvili/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@miha-plesko @miq-bot @skateman @simaishi @mzazrivec