Improve VM Chargeback Preview Report table formatting #3681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 26, 2018 17:38
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1428536 Add non-breakable class for VM Chargeback Preview Report table for better formatting.
Improve VM Chargeback Preview Report table formatting by adding` false` value as an optional argument of `report_build_html_table` to unset `word-break` css attribute.
|
@miq-bot add_label bug |
|
@miq-bot add_label pending core |
|
Checked commits hstastna/manageiq-ui-classic@0ac6a34~...2c4bd64 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@skateman @epwinchell @himdel Could you please someone look at it? Thanks! 🌟 |
|
@hstastna do we really need 2 separate PRs for this? |
|
@skateman the other PR is to main MIQ repo, this one is to ui classic repo. If you have any idea how to have just one PR to fix it, let me know :) |
|
@hstastna oh, did not notice it 😮 I think these things should be moved into ui-classic. |
|
Looks good |
|
@miq-bot remove_label pending core |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1428536
PR for main MIQ repo: ManageIQ/manageiq#17204
Improve VM Chargeback Preview Report table formatting by:
non-breakablehtml table class for VM Chargeback Preview Report tablefalsevalue as an (optional) argument ofreport_build_html_tableto achieve unsettingword-breakcss attributeBefore:
After:
