Add 'breakable' optional argument to report_build_html_table method #17204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://bugzilla.redhat.com/show_bug.cgi?id=1428536 Add 'breakable' optional argument to report_build_html_table method for fixing bad formatting of VM Chargeback Preview Report table.
|
@miq-bot add_label bug |
|
Checked commit hstastna@e9ee14e with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@skateman @epwinchell @himdel Could you please someone look at it? Thanks! 🌟 |
|
Looks good |
|
@miq-bot add_label formatting/styling |
|
@epwinchell Cannot apply the following label because they are not recognized: formatting/styling |
|
@miq-bot add_label formatting/styling |
|
@epwinchell Cannot apply the following label because they are not recognized: formatting/styling |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1428536
Depends on (PR to UI repo): ManageIQ/manageiq-ui-classic#3681
Add 'breakable' optional argument to
report_build_html_tablemethod for fixing bad formatting of VM Chargeback Preview Report table (unsetword-breakcss attribute). The purpose was not to break/edit any other tables if not needed.Before:
After:
