Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toolbar refactoring #disable_button: ViewSummary #481

Conversation

vecerek
Copy link

@vecerek vecerek commented Feb 24, 2017

Toolbar button ids Toolbar button classes edited
view_summary ViewSummary < Basic

Links

Parent issue: ManageIQ/manageiq#6259
Related issue: ManageIQ/manageiq#6554
Pivotal Tracker: https://www.pivotaltracker.com/story/show/140578079

@miq-bot
Copy link
Member

miq-bot commented Feb 24, 2017

Checked commits vecerek/manageiq-ui-classic@7f0c76d~...28d350a with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
4 files checked, 0 offenses detected
Everything looks good. 🍪

@romanblanco
Copy link
Member

Tested in UI, works fine 👍

@romanblanco
Copy link
Member

@miq-bot assign @martinpovolny

@martinpovolny martinpovolny merged commit 467dc71 into ManageIQ:master Feb 27, 2017
@martinpovolny martinpovolny added this to the Sprint 55 Ending Feb 27, 2017 milestone Feb 27, 2017
@vecerek vecerek deleted the toolbar_refactoring__disable_button__view_summary branch February 28, 2017 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants