Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor toolbar button code into separate button classes #6259

Closed
martinpovolny opened this issue Jan 20, 2016 · 5 comments
Closed

Refactor toolbar button code into separate button classes #6259

martinpovolny opened this issue Jan 20, 2016 · 5 comments
Assignees

Comments

@martinpovolny
Copy link
Member

Toolbar button special behaviors have to be handled by separate classes under app/helpers/application_helper/button.

Turn branches for specific button IDs in build_toolbar_hide_button and similar functions to such classes.

E.g. button changes from #5884 should be implemented in a separate class representing the particular buttons.

ping @romanblanco

@martinpovolny
Copy link
Member Author

See #5959 #6078 #5783

@chessbyte
Copy link
Member

@martinpovolny I see a lot of merged PRs for this issue. Is there a way to track how many remain to be converted and what completion percentage is?

@romanblanco
Copy link
Member

@chessbyte AFAIK, @vecerek has already finished or maybe missing last PR with toolbar buttons conversion

@vecerek
Copy link

vecerek commented Mar 5, 2017

@chessbyte the last 3 toolbar buttons remain to be converted

@romanblanco
Copy link
Member

@martinpovolny I believe you can close this issue now 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants