-
Notifications
You must be signed in to change notification settings - Fork 898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor toolbar button code into separate button classes #6259
Labels
Comments
This was referenced Aug 2, 2016
This was referenced Aug 5, 2016
This was referenced Aug 5, 2016
This was referenced Aug 18, 2016
This was referenced Aug 25, 2016
This was referenced Oct 4, 2016
This was referenced Feb 28, 2017
@martinpovolny I see a lot of merged PRs for this issue. Is there a way to track how many remain to be converted and what completion percentage is? |
This was referenced Mar 4, 2017
Merged
@chessbyte AFAIK, @vecerek has already finished or maybe missing last PR with toolbar buttons conversion |
@chessbyte the last 3 toolbar buttons remain to be converted |
This was referenced Mar 5, 2017
@martinpovolny I believe you can close this issue now 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Toolbar button special behaviors have to be handled by separate classes under
app/helpers/application_helper/button
.Turn branches for specific button IDs in
build_toolbar_hide_button
and similar functions to such classes.E.g. button changes from #5884 should be implemented in a separate class representing the particular buttons.
ping @romanblanco
The text was updated successfully, but these errors were encountered: