Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toolbar refactoring #disable_button: DbSeqEdit #574

Conversation

vecerek
Copy link

@vecerek vecerek commented Mar 4, 2017

Toolbar button ids Toolbar button classes created
db_seq_edit DbSeqEdit < Basic

Links

Parent issue: ManageIQ/manageiq#6259
Related issue: ManageIQ/manageiq#6554
Pivotal Tracker: https://www.pivotaltracker.com/story/show/140769293

Copy link
Member

@romanblanco romanblanco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After adding missing part, LGTM, tested in UI 👍

@@ -0,0 +1,6 @@
class ApplicationHelper::Button::DbSeqEdit < ApplicationHelper::Button::Basic
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vecerek
missing

needs :@widgetsets

@romanblanco
Copy link
Member

romanblanco commented Mar 6, 2017

@vecerek Thanks 👍
@mzazrivec ready to merge
@miq-bot assign @mzazrivec

@vecerek vecerek force-pushed the toolbar_refactoring__disable_button__db_seq_edit branch from 7e43c63 to 06be9b1 Compare March 6, 2017 20:22
@miq-bot
Copy link
Member

miq-bot commented Mar 6, 2017

Checked commits vecerek/manageiq-ui-classic@ed74e10~...06be9b1 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
4 files checked, 1 offense detected

app/helpers/application_helper/toolbar/miq_widget_sets_center.rb

@mzazrivec mzazrivec added this to the Sprint 56 Ending Mar 13, 2017 milestone Mar 6, 2017
@mzazrivec mzazrivec merged commit 1033fc3 into ManageIQ:master Mar 6, 2017
@vecerek vecerek deleted the toolbar_refactoring__disable_button__db_seq_edit branch March 6, 2017 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants