-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Toolbar refactoring #disable_button: DbSeqEdit #574
Toolbar refactoring #disable_button: DbSeqEdit #574
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After adding missing part, LGTM, tested in UI 👍
@@ -0,0 +1,6 @@ | |||
class ApplicationHelper::Button::DbSeqEdit < ApplicationHelper::Button::Basic |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vecerek
missing
needs :@widgetsets
@vecerek Thanks 👍 |
7e43c63
to
06be9b1
Compare
Checked commits vecerek/manageiq-ui-classic@ed74e10~...06be9b1 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 app/helpers/application_helper/toolbar/miq_widget_sets_center.rb
|
Links
Parent issue: ManageIQ/manageiq#6259
Related issue: ManageIQ/manageiq#6554
Pivotal Tracker: https://www.pivotaltracker.com/story/show/140769293