Toolbar refactoring #disable_button: UserRole #552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vecerek
force-pushed
the
toolbar_refactoring__disable_button__user_role
branch
from
649d415
to
cb228a9
Compare
|
This pull request is not mergeable. Please rebase and repush. |
added 3 commits
March 3, 2017 19:18
- Create spec examples for RbacUserRoleDelete button class - Implement RbacUserRole button class - Assign rbac_role_delete button to its newly created class - Remove rbac_role_delete button from #disable_button
- Create spec examples for RbacRoleEdit button class - Implement RbacRoleEdit button class - Assign rbac_role_edit button to its newly created class - Remove rbac_role_edit button from #disable_button
vecerek
force-pushed
the
toolbar_refactoring__disable_button__user_role
branch
from
cb228a9
to
7b4654b
Compare
|
Checked commits vecerek/manageiq-ui-classic@1f67b3a~...7b4654b with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 app/helpers/application_helper/toolbar/user_role_center.rb
spec/helpers/application_helper/buttons/rbac_role_delete_spec.rb
|
|
@miq-bot add_label bug |
romanblanco
approved these changes
Mar 6, 2017
|
Before: (the "Delete this Role" button should be disabled)
After:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Links
Parent issue: ManageIQ/manageiq#6259
Related issue: ManageIQ/manageiq#6554
Pivotal Tracker: https://www.pivotaltracker.com/story/show/140768853