Update ::Button::OrchestrationTemplateEditRemove methods #11078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| def disabled? | ||
| @record.in_use? | ||
| end | ||
|
|
There was a problem hiding this comment.
should have
needs_record
?
jzigmund
force-pushed
the
tb_refactoring-orchestration_templates
branch
from
806da26
to
274634c
Compare
| end | ||
| end | ||
| end | ||
| self[:title] = if self[:id] =~ /_edit$/ |
There was a problem hiding this comment.
@jzigmund I think this should be assigned to self[:title] only if disabled? returns true. It seems to me that this could lead to a situation where you would have enabled button with label saying you can not do the operation.
jzigmund
force-pushed
the
tb_refactoring-orchestration_templates
branch
from
274634c
to
8fbe42f
Compare
|
@miq-bot remove_label wip |
jzigmund
changed the title
|
@martinpovolny @romanblanco please review |
|
@jzigmund can you address rubocop's issue? |
added 2 commits
September 13, 2016 17:41
… and clean calculate_properties inside the button class
jzigmund
force-pushed
the
tb_refactoring-orchestration_templates
branch
from
8fbe42f
to
070d601
Compare
|
@jzigmund @martinpovolny otherwise, code looks good to me 👍 |
|
Checked commits jzigmund/manageiq@c2ea53f~...070d601 with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose or Intent
Updated already defined button class, used in Services/Catalogs/listnav 'Orchestration Templates'.
1st commit - Method
calculate_propertiesin::Button::Basicclass is calling thedisabled?so let the setting of the enable flag there, just calldisabled?defined in the class. Also remove the code frombuild_toolbar_disable_buttonin toolbar_builder.rb (that's the main goal of the refactoring).if @view_context.x_active_tree == :ot_tree && @recordis not needed as I found the buttons of the class generated inot_treeonly.@recordis checked before thecalculate_propertiesmethod call.2nd commit - role_allows? will be solved in #10942
Marking the PR as WIP as it needs to have solved PR mentioned above.
Links
Parent issue: #6259