Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toolbar refactoring #disable_button: Vm #553

Merged

Conversation

vecerek
Copy link

@vecerek vecerek commented Mar 2, 2017

Toolbar button ids Toolbar button classes created
instance_perf, vm_perf, container_perf VmPerf < Basic

Links

Parent issue: ManageIQ/manageiq#6259
Related issue: ManageIQ/manageiq#6554
Pivotal Tracker: https://www.pivotaltracker.com/story/show/140768867
Pending: ManageIQ/manageiq#14131

@vecerek vecerek force-pushed the toolbar_refactoring__disable_button__vm branch from a13d023 to f8d12fa Compare March 2, 2017 19:15
@miq-bot
Copy link
Member

miq-bot commented Mar 2, 2017

Checked commits vecerek/manageiq-ui-classic@cfaa4d2~...f8d12fa with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
9 files checked, 4 offenses detected

app/helpers/application_helper/toolbar/container_center.rb

app/helpers/application_helper/toolbar/openstack_vm_cloud_center.rb

app/helpers/application_helper/toolbar/x_vm_center.rb

app/helpers/application_helper/toolbar/x_vm_cloud_center.rb

Copy link
Contributor

@PanSpagetka PanSpagetka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@romanblanco
Copy link
Member

@miq-bot assign @martinpovolny

@martinpovolny martinpovolny merged commit 8e41cb5 into ManageIQ:master Mar 3, 2017
@martinpovolny martinpovolny added this to the Sprint 56 Ending Mar 13, 2017 milestone Mar 3, 2017
@vecerek vecerek deleted the toolbar_refactoring__disable_button__vm branch March 7, 2017 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants