Toolbar refactoring #disable_button: IsoDatastoreNew #516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vecerek
force-pushed
the
toolbar_refactoring__disable_button__iso_datastore_new
branch
from
176a238
to
5767aa4
Compare
|
This pull request is not mergeable. Please rebase and repush. |
added 6 commits
March 1, 2017 15:51
This method is nowhere used anyomre.
vecerek
force-pushed
the
toolbar_refactoring__disable_button__iso_datastore_new
branch
from
5767aa4
to
e4e3ee0
Compare
|
Checked commits vecerek/manageiq-ui-classic@7f4057e~...e4e3ee0 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0 app/helpers/application_helper/toolbar/iso_datastores_center.rb
|
|
Tested in UI, works fine, LGTM 👍 |
vecerek
deleted the
toolbar_refactoring__disable_button__iso_datastore_new
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Links
Parent issue: ManageIQ/manageiq#6259
Related issue: ManageIQ/manageiq#6554
Pivotal Tracker: https://www.pivotaltracker.com/story/show/140768173