Toolbar buttons converted to use generic class with disable

[romanblanco]

Continuation of #10276.

Purpose or Intent

Include buttons that share the same logic for skip? method into one generic class GenericFeatureButtonWithDisable

Links

Parent issue: #6259
Related issue: #6554

[miq-bot]

@romanblanco unrecognized command 'technical', ignoring...

Accepted commands are: add_label, remove_label, rm_label, assign, set_milestone

[miq-bot]

<pr_mergeability_checker />This pull request is not mergeable. Please rebase and repush.

[romanblanco]

@martinpovolny @PanSpagetka can you review?

[miq-bot]

Checked commits romanblanco/manageiq@6f57be8~...aee0391 with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1
2 files checked, 0 offenses detected
Everything looks good. 👍

[martinpovolny]

@dclarizio wrote:

just noticed that disabled hover text is showing for some buttons, so it is not broken everywhere . . . saw it NOT working in VMs area
seems ok in Hosts area

That matched the area that has been worked on.

This is the button that shall handle the generic behavior where button changes the hover text when enabled. Right?

Please, make sure this is fixed.

ping @PanSpagetka : please, test together making sure that all the hover texts, disable/enable show/hide remain functioning ;-)

[dclarizio]

@PanSpagetka did some testing with this branch. Compared to current master, I see now that ONLY valid power operation buttons for a VM are shown and active, which is correct.

I noticed that the disabled Configuration / Extract Running Processes button does show the reason, on both master and this branch.

However, I tried several VMs and both the Set Retirement Date and Retire this VM buttons in Lifecycle are disabled with no reason. This is the same on master and on this branch, but I would think we can always do these functions, so maybe that broke with an earlier PR. Either way, if a button is disabled, the hover text should show the reason, so I'm not sure if the bug is that they are disabled or that they don't show a reason for being disabled.

[romanblanco]

@martinpovolny wrote:

@dclarizio wrote:

just noticed that disabled hover text is showing for some buttons, so it is not broken everywhere . . . saw it NOT working in VMs area
seems ok in Hosts area

That matched the area that has been worked on.

Yes. @PanSpagetka has found my bug in recently converted buttons (VM buttons). The problem was, that I didn't set self[:enabled] attribute in calculate_properties, only self[:title], causing that buttons were always enabled, and only had the title, when they should've been disabled.

That issue is fixed in @PanSpagetka's new Generic class, where he sets both attributes, and by this conversion, the buttons are using the new Generic class, so it should work properly now.

---

@martinpovolny wrote:

This is the button that shall handle the generic behavior where button changes the hover text when enabled. Right?

Right.

There are still some buttons that are broken, but I've not converted them, as they do not have the same pattern as these.