Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toolbar refactoring #disable_button: MiqWidgetSet #528

Conversation

vecerek
Copy link

@vecerek vecerek commented Mar 1, 2017

Toolbar button ids Toolbar button classes created
db_delete DbDelete < Basic

Links

Parent issue: ManageIQ/manageiq#6259
Related issue: ManageIQ/manageiq#6554
Pivotal Tracker: https://www.pivotaltracker.com/story/show/140768407

@vecerek vecerek changed the title Toolbar refactoring disable button miq widget set Toolbar refactoring #disable button: MiqWidgetSet Mar 1, 2017
@miq-bot
Copy link
Member

miq-bot commented Mar 2, 2017

This pull request is not mergeable. Please rebase and repush.

@vecerek vecerek changed the title Toolbar refactoring #disable button: MiqWidgetSet Toolbar refactoring #disable_button: MiqWidgetSet Mar 2, 2017
@vecerek vecerek force-pushed the toolbar_refactoring__disable_button__miq_widget_set branch from 22307fe to a924660 Compare March 2, 2017 22:08
Copy link
Member

@romanblanco romanblanco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in UI, works good 👍

@romanblanco
Copy link
Member

@miq-bot assign @martinpovolny

@martinpovolny
Copy link
Member

@vecerek : please, rebase

@miq-bot
Copy link
Member

miq-bot commented Mar 3, 2017

This pull request is not mergeable. Please rebase and repush.

@vecerek vecerek force-pushed the toolbar_refactoring__disable_button__miq_widget_set branch from a924660 to 389f8e8 Compare March 3, 2017 18:40
@miq-bot
Copy link
Member

miq-bot commented Mar 3, 2017

Checked commits vecerek/manageiq-ui-classic@521d324~...389f8e8 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
4 files checked, 1 offense detected

app/helpers/application_helper/toolbar/miq_widget_set_center.rb

@martinpovolny martinpovolny added this to the Sprint 56 Ending Mar 13, 2017 milestone Mar 6, 2017
@martinpovolny martinpovolny merged commit 0b5bebe into ManageIQ:master Mar 6, 2017
@vecerek vecerek deleted the toolbar_refactoring__disable_button__miq_widget_set branch March 7, 2017 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants